Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Also check for inf in spaxel tool #3368

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 19, 2024

Description

This pull request is to fix #3362 .

The fix is so tiny... Do we really need a change log or test here, @rosteen ?

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two labels Dec 19, 2024
@pllim pllim added this to the 4.1 milestone Dec 19, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (18a740d) to head (10d7270).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
- Coverage   88.17%   88.12%   -0.06%     
==========================================
  Files         127      127              
  Lines       19489    19532      +43     
==========================================
+ Hits        17185    17212      +27     
- Misses       2304     2320      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen
Copy link
Collaborator

rosteen commented Dec 20, 2024

This might fix the error traceback, but I don't think it results in the behavior that we want. Even if half the spectrum at a given spatial location is NaN, we still want to show the other half. I'm pretty sure this worked before but I don't know what would have changed to break it.

@pllim
Copy link
Contributor Author

pllim commented Dec 20, 2024

@rosteen good catch, my previous check was flawed. I changed all to any. Does this address your concern? The root of the problem is that the uncert has data that is all inf and it was not caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Spectrum-at-spaxel tool raises JSON warnings in uncertainy viewer
2 participants