retrieve version from package #1648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
build/fix_build_workflow
branch
from
c054982 to
7607712
Compare
zacharyburnett
force-pushed
the
build/fix_build_workflow
branch
from
b600c81 to
e930d84
Compare
zacharyburnett
changed the title
zacharyburnett
commented
Oct 14, 2024
Comment on lines
+46
to
+47
| name: retrieve package version | ||
| run: echo version=$(python -c "import jwql; print(jwql.__version__)") >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
we don't even have to use dunamai here, we can just use the pre-populated __version__
| @@ -10,4 +12,4 @@ | |||
| f"while JWQL is using {__version__}") | |||
|
|
|||
| except FileNotFoundError: | |||
| print('Could not determine jwql config version') | |||
| warnings.warn('Could not determine jwql config version') | |||
There was a problem hiding this comment.
when this was print(, it was polluting the output of import jwql; print(jwql.__version__) in the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix issue in the build workflow where the
dunamaiversion retrieval action wasn't able to find themicromambaenvironment (and so attempted to installdunamaito the system Python installation, which failed)upon further reflection on this we don't even need to use
dunamaiat all, we can just get the version fromjwql.__version__, no need to make this complicated