Ignored config parameters #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should probably do a few more tests here before considering this ready to go. Initial tests all looked good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50
Tweaks to the logic used for overriding parameter values from various sources. Previously the values from the command line (including defaults for entries not explicitly added by the user) were overriding values from the config file if they were not None or an empty list. This meant that any parameter with a default that wasn't None or an empty list was overriding the value from the config file. With this change, values from the command line override existing values only if the value from the command line is not equal to the default values (as defined in constants.py).
The one case where this may be a problem is if a user has a config file where a parameter has a non-default value, and then they try to set it back to a default value on the command line. This seems like a low-probability situation though.