Skip to content

Commit 527ce58

Browse files
kecnrymeeseeksmachine
authored andcommitted
Backport PR #137: improve initial scatter/mouseover performance
1 parent 7e691b7 commit 527ce58

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGES.rst

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33

44
* bumps lightkurve to 2.5.0 to include upstream bug fixes. [#132]
55

6+
* Improve scatter viewer and mouseover performance. [#137]
7+
68

79
0.4.2 (07.23.2024)
810
------------------

lcviz/plugins/coords_info/coords_info.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,7 @@ def _cursor_fallback():
8989
if self.dataset.selected != 'auto' and self.dataset.selected != lyr.layer.label:
9090
continue
9191

92-
# glue-jupyter 1.18 changed from lyr.scatter to lyr.scatter_mark
93-
# TODO: once glue-jupyter is pinned to 1.18 or later, update this to:
94-
# scatter = lyr.scatter_mark
95-
scatter = getattr(lyr, 'scatter_mark', getattr(lyr, 'scatter', None))
92+
scatter = lyr.scatter_mark
9693
lyr_x, lyr_y = scatter.x, scatter.y
9794
if not len(lyr_x):
9895
continue

lcviz/viewers.py

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ def _apply_layer_defaults(self, layer_state):
149149
if getattr(layer_state.layer, 'meta', {}).get('Plugin', None) == 'Binning':
150150
# increased size of binned results, by default
151151
layer_state.size = 5
152+
layer_state.points_mode = 'markers'
152153

153154
def set_plot_axes(self):
154155
# set which components should be plotted

0 commit comments

Comments
 (0)