diff --git a/CHANGES.rst b/CHANGES.rst index 03b79480..94bcaabf 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -1,11 +1,18 @@ -0.6.0 (unreleased) -================== +0.6.0 (22-01-14) +================ ramp_fitting ------------ - Adding GLS code back to ramp fitting. [#64] +jump +---- + +- Fix issue in jump detection that occured when there were only 2 usable + differences with no other groups flagged. This PR also added tests and + fixed some of the logging statements in twopoint difference. [#74] + 0.5.1 (2022-01-07) ================== diff --git a/src/stcal/jump/twopoint_difference.py b/src/stcal/jump/twopoint_difference.py index e545eb05..8c9b5614 100644 --- a/src/stcal/jump/twopoint_difference.py +++ b/src/stcal/jump/twopoint_difference.py @@ -125,12 +125,10 @@ def find_crs(dataa, group_dq, read_noise, normal_rej_thresh, row2cr, col2cr = np.where(np.logical_and(ndiffs - num_unusable_groups == 2, max_ratio > two_diff_rej_thresh)) - log.info(f'From highest outlier Two-point found {len(row4cr)} pixels \ - with at least one CR and at least five groups') - log.info(f'From highest outlier Two-point found {len(row3cr)} pixels \ - with at least one CR and four groups') - log.info(f'From highest outlier Two-point found {len(row2cr)} pixels \ - with at least one CR and three groups') + log_str = 'From highest outlier, two-point found {} pixels with at least one CR from {} groups.' + log.info(log_str.format(len(row4cr), 'five')) + log.info(log_str.format(len(row3cr), 'four')) + log.info(log_str.format(len(row2cr), 'three')) # get the rows, col pairs for all pixels with at least one CR all_crs_row = np.concatenate((row4cr, row3cr, row2cr))