Add test cases for server.rs
#34
Conversation
| @@ -135,7 +137,7 @@ impl Server { | |||
| } | |||
| } | |||
|
|
|||
| pub async fn start(&mut self) { | |||
| pub async fn start(&mut self, rx: Option<mpsc::Receiver<()>>) { | |||
There was a problem hiding this comment.
I understand this PR is still in Draft, but why do you wanna introduce a channel over here ?
There was a problem hiding this comment.
Hey 👋🏻
No worries, feel free to review anytime I'm completely fine with it.
This is added because if I don't pass some sort of signal, the test case will keep running forever because of the infinite loop. I couldn't think of any better approach than this that's why I consider it optional so actual implementation/usage won't have to pass any value. I'm planning to add it in other methods too where we have an infinite loop.
I'm happy to learn some new techniques/patterns if you can share them here.
Thanks!
|
any progress here? |
someone reached out on the issue and I gave my comment, not sure after that. Thanks! |
|
closing due to inactivity. |
Closes: #21
Changes proposed in the MR:
mpsc::channelinserver.startmethod to stop based on the communication as this is required for writing test case elseloopwill continue forever.pub async fn new(id: u32, config: ServerConfig, cluster_config: ClusterConfig) -> Server {pub async fn start(&mut self, rx: Option<mpsc::Receiver<()>>) {pub fn is_leader(&self) -> bool {async fn follower(&mut self) {async fn candidate(&mut self) {async fn leader(&mut self) {async fn receive_rpc(&mut self) {async fn handle_rpc(&mut self, data: Vec<u8>) {async fn handle_client_request(&mut self, data: Vec<u8>) {async fn handle_request_vote(&mut self, data: &[u8]) {async fn handle_request_vote_response(&mut self, data: &[u8]) {async fn handle_append_entries(&mut self, data: Vec<u8>) {async fn handle_append_entries_response(&mut self, data: &[u8]) {async fn handle_heartbeat(&mut self, data: &[u8]) {async fn handle_heartbeat_response(&mut self) {async fn handle_repair_request(&mut self, data: &[u8]) {async fn handle_repair_response(&mut self, data: &[u8]) {async fn handle_join_request(&mut self, data: &[u8]) {async fn handle_join_response(&mut self, data: &[u8]) {async fn persist_to_disk(&mut self, id: u32, data: &[u8]) {async fn stop(self) {