Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing C++ Guards in hci_drv_apollo3.h #20

Open
oclyke opened this issue Jul 28, 2020 · 1 comment
Open

Missing C++ Guards in hci_drv_apollo3.h #20

oclyke opened this issue Jul 28, 2020 · 1 comment
Labels
2.5.1

Comments

@oclyke
Copy link
Contributor

oclyke commented Jul 28, 2020 •
edited
Loading

The header file hci_drv_apollo3.h (located in third_party/exactle/ble-host/sources/hci/ambiq/apollo3/) is missing C++ extern "C" guards. This makes it more difficult to use this interface from C++ sources.

A patch is available in branch 2.4.2-patch-cpp-guards-hci-drv-apollo3-h
The patch is included in the current master branch as well.
@oclyke oclyke mentioned this issue Jul 28, 2020
Merged
@oclyke
Copy link
Contributor Author

oclyke commented Oct 2, 2020

This issue still exists in AmbiqSuite release 2.5.1. The file in question is now called: third_party/cordio/ble-host/sources/hci/ambiq/apollo3/hci_drv_apollo3.h

oclyke pushed a commit that referenced this issue Oct 5, 2020
add __cplusplus guards
58ffc86 
addresses #20
@oclyke oclyke added the 2.5.1 label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.5.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oclyke