Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Disable UART FIFO via HAL #25

Open
oclyke opened this issue Sep 8, 2020 · 2 comments
Open

Cannot Disable UART FIFO via HAL #25

oclyke opened this issue Sep 8, 2020 · 2 comments
Labels
2.5.1

Comments

@oclyke
Copy link
Contributor

oclyke commented Sep 8, 2020 •
edited
Loading

As evidenced by changes required for this PR in the mbed port it is difficult to fully disable the FIFO on UART while using HAL configuration.

branch 2.4.2-patch-uart-fifo-config adds an additional configuration function which allows the FIFO to be enabled (as usual) or disabled (addtl. feature)
oclyke pushed a commit that referenced this issue Oct 2, 2020
add am_hal_uart_configure_fifo function
1e4e5ce 
addresses #25
@oclyke oclyke added the 2.5.1 label Oct 5, 2020
@oclyke
Copy link
Contributor Author

oclyke commented Oct 5, 2020

This issue persists in AmbiqSuite SDK 2.5.1 and has a corresponding patch branch

@RichardSWheatley
Copy link

I do not believe your fix works. I believe it does the opposite.
buffer_configure already handles the NULL pointers properly whereas you new function ignores the NULL handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.5.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RichardSWheatley @oclyke