Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate custom version comparators #2639

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Deprecate custom version comparators #2639

merged 4 commits into from
Oct 7, 2024

Conversation

zorgiepoo
Copy link
Member

Fixes #2585

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Sep 30, 2024
@github-actions GitHub Actions
Copy link

/Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:463:1: warning: implementing deprecated method [-Wdeprecated-implementations] - (id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)__unused updater ^ In file included from /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:15: /Users/runner/work/Sparkle/Sparkle/Sparkle/SPUUpdaterDelegate.h:389:1: note: method 'versionComparatorForUpdater:' declared here - (nullable id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)updater __deprecated_msg("Custom version comparators are deprecated because they are incompatible with how the system compares different versions of an app."); ^ 1 warning generated. /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:463:1: warning: implementing deprecated method [-Wdeprecated-implementations] - (id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)__unused updater ^ In file included from /Users/runner/work/Sparkle/Sparkle/Sparkle/SUUpdater.m:15: /Users/runner/work/Sparkle/Sparkle/Sparkle/SPUUpdaterDelegate.h:389:1: note: method 'versionComparatorForUpdater:' declared here - (nullable id<SUVersionComparison>)versionComparatorForUpdater:(SPUUpdater *)updater __deprecated_msg("Custom version comparators are deprecated because they are incompatible with how the system compares different versions of an app."); ^ 1 warning generated. note: Run script build phase 'Strip Framework' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Set Git Version Info' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle') note: Run script build phase 'Run Script: Link Tools' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Sparkle' from project 'Sparkle')

@zorgiepoo zorgiepoo merged commit 544c642 into 2.x Oct 7, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the deprecate-custom-comparators branch October 7, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.

Deprecate custom version comparators
1 participant
@zorgiepoo