Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip preflight update check in sparkle-cli if user is root #2645

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Skip preflight update check in sparkle-cli if user is root #2645

merged 1 commit into from
Oct 12, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Oct 12, 2024 •
edited
Loading

Fixes issue brought up in #2644

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested pkg update installation from sparkle-cli as root user without --interactive, and as non-root user which required --interactive.

macOS version tested: 15.0.1 (24A348)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Oct 12, 2024
@zorgiepoo zorgiepoo merged commit f3dc125 into 2.x Oct 12, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the sparkle-cli-root-user branch October 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
1 participant
@zorgiepoo