From ad199dbcf26dd4f4e48095142396153addb8ff7b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Jan 2024 05:16:31 +0000 Subject: [PATCH 1/2] build(deps-dev): update rubocop-minitest requirement Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-minitest/compare/v0.34.3...v0.34.5) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 5149deae..da17ec77 100644 --- a/Gemfile +++ b/Gemfile @@ -13,6 +13,6 @@ group :development do gem "rdoc", "6.6.2" gem "rubocop", "1.59.0", require: false - gem "rubocop-minitest", "0.34.3", require: false + gem "rubocop-minitest", "0.34.5", require: false gem "standard", "1.33.0", require: false end From a3bd673361fa45930c1970940c6c6112e51d4b96 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Mon, 29 Jan 2024 17:02:41 -0500 Subject: [PATCH 2/2] style(rubocop): Minitest/AssertKindOf --- test/test_integration_resultset.rb | 8 ++++---- test/test_statement.rb | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test_integration_resultset.rb b/test/test_integration_resultset.rb index bea28a8f..531d6154 100644 --- a/test/test_integration_resultset.rb +++ b/test/test_integration_resultset.rb @@ -92,10 +92,10 @@ def test_real_translation @db.execute("insert into foo_real values (42)") @db.query("select a, sum(a), typeof(a), typeof(sum(a)) from foo_real") do |result| result = result.next - assert result[0].is_a?(Float) - assert result[1].is_a?(Float) - assert result[2].is_a?(String) - assert result[3].is_a?(String) + assert_kind_of Float, result[0] + assert_kind_of Float, result[1] + assert_kind_of String, result[2] + assert_kind_of String, result[3] end end diff --git a/test/test_statement.rb b/test/test_statement.rb index c74f9a22..0b74fdb7 100644 --- a/test/test_statement.rb +++ b/test/test_statement.rb @@ -326,7 +326,7 @@ def test_clear_bindings! end def test_stat - assert @stmt.stat.is_a?(Hash) + assert_kind_of Hash, @stmt.stat end def test_stat_fullscan_steps