-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLite3::Database#execute_batch fails with non-ASCII characters #524
Comments
@Math2 Thanks for reporting this. I'll take a look! |
Bisecting indicates a9a89f8 is the commit that introduced this behavior. It looks like the "tail" string comes back from I've got a fix, just writing up some tests and I'll create the PR shortly. |
flavorjones
added a commit
that referenced
this issue
Apr 19, 2024
Fix a regression in v2.0.0 that caused `Database#execute_batch` to raise an encoding exception when passed some non-ASCII strings. As a result of this fix, `Database#prepare` now ensures the "remainder" string will always be encoded as UTF-8. Closes #524
See #526 for the proposed fix. |
flavorjones
added a commit
that referenced
this issue
Apr 20, 2024
Fix a regression in v2.0.0 that caused `Database#execute_batch` to raise an encoding exception when passed some non-ASCII strings. As a result of this fix, `Database#prepare` now ensures the "remainder" string will always be encoded as UTF-8. Closes #524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before v2.0.0, the following used to work:
But now fails with:
The text was updated successfully, but these errors were encountered: