Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smarter label renaming if only a single UTXO for each address #1601

Closed
AndySchroder opened this issue Jan 21, 2025 · 3 comments
Closed

smarter label renaming if only a single UTXO for each address #1601

AndySchroder opened this issue Jan 21, 2025 · 3 comments

Comments

@AndySchroder
Copy link

When changing a label for an address, if there is only a single UTXO associated with that address, also rename that UTXO to have the same label.

Similarly, if we rename the UTXO and there are no other UTXO for the address, rename the address label as well.

Similarly, if the address or UTXO that we are renaming is only part of a transaction where no other UTXO or addresses in the wallet are used, the transaction should also be renamed.

@craigraw
Copy link
Collaborator

This is (in general) how it already works. There are some restrictions when labelling UTXOs to avoid many (recursive) changes on wallets with high address reuse.

@AndySchroder
Copy link
Author

Are you able to test these scenarios? I'm struggling to get them all to consistently work right even with a single UTXO associated with and address.

#1600 is a related issue. It seems when I rename a transaction, other things get renamed, but not always in the right way.

@craigraw
Copy link
Collaborator

Can you provide a reproducible series of steps to demonstrate what you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants