Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks #38

Open
3 tasks
vil1 opened this issue Jan 13, 2019 · 2 comments
Open
3 tasks

Add benchmarks #38

vil1 opened this issue Jan 13, 2019 · 2 comments

Comments

@vil1
Copy link
Member

vil1 commented Jan 13, 2019

We need a benchmarks sbt module with benchmarks for the functors produced by all our interpreters.

As satisfying first iteration would:

  • define a "meaningful" example schema (complex enough to contain at least one instance of every members of the Schema ADT).
  • for each interpreter, provide an "honest" implementation of the same functor, as it would be implemented "by hand" in real-life. For example, implement a play.api.libs.json.Reads using the Json.reads macro.
  • compare performances of both the derived and the manually implemented functor to come up with a performance score.
@plokhotnyuk
Copy link

Please, do not use the most inefficient JSON library for growing a new one... It will be too hard to spot any changes in performance and allocation rate with it.

Let's compare with one of the fastest, like jsoniter-scala which already has a quite efficient derivation by a macro that is on par with the manual one in runtime.

@vil1
Copy link
Member Author

vil1 commented Jan 13, 2019

I think your comment would be more relevant to #32, see you there ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants