-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Audacity's WASAPI patched portaudio source #6
Comments
Thanks for the suggestion! |
Oops, didn't see the email for this! As for why, I'm not entirely sure. The only thing I could find was on the Audacity wiki: "Often the version of PortAudio used in Audacity has patches that have yet to make it back to the PortAudio SVN." |
OK, so you (or somebody) should find out if this is planned to be included in the original PortAudio. Is there an open issue or pull request for that? Once there is a pull request (or at least a published patch somewhere), this can be added to MXE, which is what I'm actually using to create the Windows binaries. |
This would still be spectacularly useful, what do you think is the best way to progress this forward? |
That's exactly what I tried to describe in my previous comment, which is a few years old, but AFAIK nothing has changed since (except probably that the MXE project has become a little less active). I guess answering the question I've asked above would be a good first step. In fact, I've asked two questions. The answer to either one would help. This may need some searching on the PortAudio issue tracker and probably even needs some additional communication with the PortAudio team. |
We (LedFx team) have made a PR for this - if you have any comments/want to review the PR, please have a look and comment if required. |
Thanks for creating a PR for that! With that, a loopback device should be created automatically, right? So I guess we should not need any change in the However, we might think about supporting the additional API function |
A quick and dirty way of finding the loopbacks is probably to find any device that has the same name as an WASAPI output device with "[Loopback]" appended to the end of it and input channels. We're still squishing some bugs on that PR, and then there will obviously need to be a review and then wait for a release etc edit: updated to reflect new loopback postfix formatting. |
The PR is ready for testing - if anyone wants to build from my fork and test comments would be appreciated - PortAudio/portaudio#672 |
@shauneccles I would like to correct regarding the use of So my advise is either:
Postfixing WASAPI device name with |
Correct - the postfix has been updated since my comment - I'll update now :) Thanks so much for your help @dmitrykos |
Thanks everyone for pushing this forward! I've created spatialaudio/python-sounddevice#392, which makes the new Any suggestions? |
A few options I think - I wonder if as part of input device creation you Alternatively, putting it inside |
Audacity has patched version of portaudio in their source tree that implements support for WASAPI loopback mode, which allows you to capture from an output. It could be useful for some.
The text was updated successfully, but these errors were encountered: