Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http_build_query vs concat strings + traits vs inheritance ? #195

Closed
vever001 opened this issue May 28, 2024 · 1 comment
Closed

Use http_build_query vs concat strings + traits vs inheritance ? #195

vever001 opened this issue May 28, 2024 · 1 comment

Comments

@vever001
Copy link
Contributor

What do you want to achieve?

Please check Package principles before you create a request.

Hi, while working on #192 I had experimented with using http_build_query in vever001@39a9bbd
It URL-encodes all params but as I recall it doesn't break anything.
The inheritance for outlook generators was also replaced with a trait.

This is just an issue to discuss whether it is worth pursuing or not.
Let me know :)

@spatie-bot
Copy link

Dear contributor,

because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants