Make sure new calls are also filtered by definedIn
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
commented
Jun 23, 2023
spaze
reviewed
Jul 1, 2023
spaze
force-pushed
the
feat/fix-new-disallow-in-calls
branch
from
3e43ec3
to
7da5e66
Compare
|
Hey, nice catch and nice fix, thank you! I have moved the added iterator return types into a separate commit and removed an empty line here and added it there and have also removed the |
|
Now released in 2.15.1, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some issues with the new
definedIn(#198), where it would report allnewcalls, to built in classes, as it had nodefinedIn, and since it wasn't passed along.