Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All of the 'loadedmetadata' listeners are removed by this plugin #109

Open
mig8447 opened this issue Dec 24, 2020 · 0 comments
Open

All of the 'loadedmetadata' listeners are removed by this plugin #109

mig8447 opened this issue Dec 24, 2020 · 0 comments

Comments

@mig8447
Copy link

mig8447 commented Dec 24, 2020

The excerpt below removes all player's loadedmetadata listeners

videojs-markers/src/videojs.markers.js

Line 449 in 7ae4b86

player.off("loadedmetadata");

The below excerpt should instead be changed to player.one( ... ) to avoid this

videojs-markers/src/videojs.markers.js

Line 453 in 7ae4b86

player.on("loadedmetadata", function() {

mig8447 added a commit to mig8447/videojs-markers that referenced this issue Dec 24, 2020
@mig8447
Bump to 1.0.2, fixing spchuang#109
0c8cff2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mig8447