Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IModelStore.IdType.Unkown should be IModelStore.IdType.Unknown #19

Open
Tracked by #288
dwalluck opened this issue Jan 22, 2025 · 4 comments
Open
Tracked by #288

IModelStore.IdType.Unkown should be IModelStore.IdType.Unknown #19

dwalluck opened this issue Jan 22, 2025 · 4 comments

Comments

@dwalluck
Copy link
Contributor

No description provided.

@goneall
Copy link
Member

goneall commented Jan 22, 2025

Thanks @dwalluck - I need a better spell checker for the code!

@bact
Copy link
Collaborator

bact commented Jan 22, 2025

The renaming of the enum can be complicated

See #8 and spdx/Spdx-Java-Library#266 (comment)

@dwalluck
Copy link
Contributor Author

We can keep the old one and mark it as deprecated as we have done with the methods.

In fact, changing (removing) this will break the Library code, but the Library code can be changed afterwards if the old one is kept in the meantime.

@goneall
Copy link
Member

goneall commented Jan 24, 2025

It will be a bit complex in the library code to change all the places where this is written to use the new version and all the places which have conditionals to check both spellings - but it is doable with a reasonable amount of effort.

The good news is that this particular enum value is not used very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants