-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check license button no longer works #527
Comments
On the production server, there is a static directory, but it doesn't contain the utils.js. Here's the contents of
|
I could not locate the file I tried running the collect static command manually - here's the output: |
What is the expected behavior of the tool at https://tools.spdx.org/app/check_license/ ? The interface itself does not very telling. |
The expected behavior is to compare the submitted text against all listed licenses and listed license exceptions. The result of the compare would be one of "Exact Match", "Close Match" or "No Match". Exact match only if it matches using the license matching guidelines. The implementation of close match is it achieve a high score on a text matching algorithm (e.g. Sørensen Dice) but does not pass the full matching guidelines. There are two main use cases:
|
Thank you |
I have tried Apache Nothing matched |
It works from the full text of the license - not the license ID. Try copy/pasting the official license text from the website: https://spdx.org/licenses/Apache-2.0.html |
Got it. Thank you |
@goneall I think the app is working now. I have tested it with the full text from https://spdx.org/licenses/Apache-2.0.html, hit the "Check License" button and got a dialog box reporting a result as "Close match". The button is working. -- Tested on Firefox 133, Chrome 131, and Safari 17.6 |
I put these usage/behaviour to the Check License UI in PR #545 |
The check license menu does work, but the "check license" button on the license submittal page still doesn't work on my web browser (chrome). @bact - let me know if you see the same issue |
I see. That's a different page. |
Does it possible to copy https://github.com/spdx/spdx-online-tools/blob/main/src/app/static/js/utils.js over there? |
Interesting - this should have been copied over during the docker build: spdx-online-tools/dockerfile.prod Line 29 in da1793a
It copied everything else. I didn't capture the output of the docker build - next time I do a release, I'll have to capture the output and see if there is a clue as to why it either didn't get copied or it got deleted. |
BTW - I did verify it is in the directory for the server where the docker build was done. Here's the output of ls on the machine where I ran the docker build:
and here's the output of the ls in the container:
|
After updating to the latest release (1.2.3), clicking the check license button does not return anything.
In looking in the browser debug console message, it looks like it can't find the file
https://tools.spdx.org/static/js/utils.js
.Perhaps the get static didn't execute successfully or it is in the wrong place.
Below is the console output:
The text was updated successfully, but these errors were encountered: