From e4b55be8a34c4ae8d744002014da23ea7bf005d1 Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 10:12:48 -0400 Subject: [PATCH 1/6] fix [DEP0066] warning for node > 10.x --- lib/spdy/response.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spdy/response.js b/lib/spdy/response.js index e607918..5b97754 100644 --- a/lib/spdy/response.js +++ b/lib/spdy/response.js @@ -15,7 +15,7 @@ exports.writeHead = function writeHead (statusCode, reason, obj) { } this.statusCode = statusCode - if (this._headers) { + if (this.getHeaders()) { // Slow-case: when progressive API and header fields are passed. if (obj) { var keys = Object.keys(obj) From fd0dcb17d981555cbc2961cd3aa6283b40d250ef Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 10:39:58 -0400 Subject: [PATCH 2/6] fix [DEP0066] warning for node > 10.x. Add support for Node < 7.x --- lib/spdy/response.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/spdy/response.js b/lib/spdy/response.js index 5b97754..4dd8d27 100644 --- a/lib/spdy/response.js +++ b/lib/spdy/response.js @@ -15,7 +15,8 @@ exports.writeHead = function writeHead (statusCode, reason, obj) { } this.statusCode = statusCode - if (this.getHeaders()) { + var resHeaders = res.getHeaders ? res.getHeaders() : res._headers; + if (resHeaders) { // Slow-case: when progressive API and header fields are passed. if (obj) { var keys = Object.keys(obj) From 6dea5a91725e6f2cd46bde6130d675258d220059 Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 10:48:07 -0400 Subject: [PATCH 3/6] fix context --- lib/spdy/response.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spdy/response.js b/lib/spdy/response.js index 4dd8d27..1404220 100644 --- a/lib/spdy/response.js +++ b/lib/spdy/response.js @@ -15,7 +15,7 @@ exports.writeHead = function writeHead (statusCode, reason, obj) { } this.statusCode = statusCode - var resHeaders = res.getHeaders ? res.getHeaders() : res._headers; + var resHeaders = this.getHeaders ? this.getHeaders() : this._headers; if (resHeaders) { // Slow-case: when progressive API and header fields are passed. if (obj) { From c08ba46a8f9ca618accf6b71653c52846d28c457 Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 10:52:54 -0400 Subject: [PATCH 4/6] fix context --- lib/spdy/response.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spdy/response.js b/lib/spdy/response.js index 1404220..d951a8d 100644 --- a/lib/spdy/response.js +++ b/lib/spdy/response.js @@ -15,7 +15,7 @@ exports.writeHead = function writeHead (statusCode, reason, obj) { } this.statusCode = statusCode - var resHeaders = this.getHeaders ? this.getHeaders() : this._headers; + var resHeaders = this.getHeaders ? this.getHeaders() : this._headers if (resHeaders) { // Slow-case: when progressive API and header fields are passed. if (obj) { From 69bb85594ee9d1efc6895ca647e533fe5ceab4f7 Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 10:56:31 -0400 Subject: [PATCH 5/6] add node 12 in CI --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 8023999..2d4ed12 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,6 +6,7 @@ node_js: - "6" - "8" - "10" + - "12" script: - npm run lint From baa4a83c55456e43d183c7ab2a9c0b6692983a07 Mon Sep 17 00:00:00 2001 From: Florentin Thullier Date: Fri, 24 Apr 2020 13:37:41 -0400 Subject: [PATCH 6/6] fix another [DEP0066] warning triggered in agent. Still some work needed on tests to support node 12.x --- lib/spdy/agent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/spdy/agent.js b/lib/spdy/agent.js index 4adc524..7f77e24 100644 --- a/lib/spdy/agent.js +++ b/lib/spdy/agent.js @@ -248,7 +248,7 @@ proto._createStream = function _createStream (req, handle) { return state.connection.reserveStream({ method: req.method, path: req.path, - headers: req._headers, + headers: req.getHeaders ? req.getHeaders() : req._headers, host: state.host }, function (err, stream) { if (err) {