Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong param in asset URL creation in SP7 #6160

Open
acwhite211 opened this issue Jan 27, 2025 · 2 comments · May be fixed by #6176
Open

Wrong param in asset URL creation in SP7 #6160

acwhite211 opened this issue Jan 27, 2025 · 2 comments · May be fixed by #6176
Assignees
Labels
2 - Attachments Issues that are related to attachments
Milestone

Comments

@acwhite211
Copy link
Member

acwhite211 commented Jan 27, 2025

For some instances in production, when Specify tries to fetch the assets, it does not correctly build the URL to fetch successfully from the assets server. In the params for the asset URL, the 'coll' param is not getting correctly set. The convention that has been used on the asset server is for the 'coll' param to be set to the institutions name / acronym. This is the behavior in 7.9.6.2. In production, the 'coll' param is being set to the name of the current collection or something else, not the institution name, thus it is failing to retrieve the assets.

Wrong URL example: https://assets1.specifycloud.org/fileget?coll=teste&type=T&filename=7ab24b22-0c68-4ca7-b712-18f9603d789f.pdf&scale=123
Correct URL example: https://assets1.specifycloud.org/fileget?coll=entomologiamnrj&type=T&filename=7ab24b22-0c68-4ca7-b712-18f9603d789f.pdf&scale=123

production behavior:
Image

v7.9.6.2 bahavior:
Image

Steps to reproduce the behavior:

  1. Open the assets page

Please fill out the following information manually:

  • OS: Mac OS
  • Browser: Firefox
  • Specify 7 Version: production
  • Database Name: entomologiamnrj
  • Collection name: all
  • User Name: SpAdmin
@acwhite211 acwhite211 self-assigned this Jan 27, 2025
@acwhite211 acwhite211 added the 2 - Attachments Issues that are related to attachments label Jan 27, 2025
@grantfitzsimmons grantfitzsimmons added this to the 7.10 milestone Jan 29, 2025
@acwhite211
Copy link
Member Author

Haven't been able to replicate on the test-panel, so I think it is just something with my local instance setup. Not sure exactly why, but I don't think it is a critical issue.

@CarolineDenis CarolineDenis modified the milestones: 7.10, 7.10.1 Jan 29, 2025
@acwhite211 acwhite211 linked a pull request Jan 29, 2025 that will close this issue
2 tasks
@acwhite211
Copy link
Member Author

It seems the API call to /context/attachment_settings.json returns the wrong value for coll. I created a draft PR with an easy fix. Will investigate more to see if there is another solution.
#6176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Attachments Issues that are related to attachments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants