Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workbench validation for cotype #6194

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Add workbench validation for cotype #6194

merged 6 commits into from
Feb 5, 2025

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Feb 4, 2025 •
edited
Loading

Fixes #6187

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Create a WB dataset that maps COType and Taxons
  • Add a row where COType tree definition does not belong to the Taxon in that row
  • Validate
  • Verify there is a validation error for entered COType

@sharadsw sharadsw added this to the 7.10.1 milestone Feb 4, 2025
@sharadsw sharadsw requested a review from melton-jason February 4, 2025 17:33
@sharadsw sharadsw requested review from pashiav and a team February 5, 2025 15:10
@sharadsw sharadsw assigned alesan99 and unassigned alesan99 Feb 5, 2025
@sharadsw sharadsw requested a review from alesan99 February 5, 2025 15:10
alesan99
alesan99 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Verify there is a validation error for entered COType

image

The validation error is being shown when appropriate 👍👍👍

pashiav
pashiav approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify there is a validation error for entered COType

Looks good!

Screenshot 2025-02-05 at 11 34 21 AM

@sharadsw sharadsw marked this pull request as ready for review February 5, 2025 17:46
@sharadsw sharadsw mentioned this pull request Feb 5, 2025
Open
@sharadsw sharadsw merged commit 4be07f5 into production Feb 5, 2025
12 checks passed
@sharadsw sharadsw deleted the issue-6187 branch February 5, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alesan99 alesan99 alesan99 approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@pashiav pashiav pashiav approved these changes

@melton-jason melton-jason Awaiting requested review from melton-jason

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.10.1
Development

Successfully merging this pull request may close these issues.

WB does not always match COT to determination
5 participants
@sharadsw @alesan99 @CarolineDenis @pashiav @acwhite211