-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Improvement: Options for only the first 10 column families are reported to the log #430
Comments
@udi-speedb, do you know if these options are printed to the OPTIONS file? |
also, i dont know if this is a bug since its definitely intentional |
|
I was working on something earlier that would only print/return options that were different than the default. This could be useful if we wanted to keep the logs (or options files) shorter and pruned. I can try to resurrect that code... |
@mrambacher As part of the log parser tool, I am displaying a diff between baseline options files (options files that are generated from official RocksDB / Speedb releases whose values are the defaults for that release) and options as displayed in the log file. |
Until this issue is resolved, I have added #520 I am not sure if reporting the options for all of the cf-s is a valid solution when there are many cf-s. My concerns with reporting all of the options is that, when there are many cf-s (their number is not limited), we may bloat the log file with the text reporting the options of all of the cf-s. This may be a bigger issue when log files are rotated frequently, as the options are reported at the top of every rolled log. |
thats why @mrambacher suggestion of reporting only the options that are different than the first cf is a great one. i believe doing this is irrelevant of the log-parser and it would have several beneficial effects:
|
I agree.
|
@mrambacher - Please attach a sample log output when you have one ready, so we would be able to better understand how that would look (and also estimate the effort of the log parser's adaptation). |
@mrambacher - Could you please add a reference for the pr-s on which you rely as infrastructure for this one? |
This is being resolved in stages that will require several PRs:
There will also be a subsequent PR that brings this altogether and removes the cap of the number of CFs that are written. |
The options of column families are reported to the log at the top of every log file. However, if there are more than 10 column families (not very common but definitely allowed and occurs in practice), only the options of the first 10 are reported to the log.
Throughout the log file, any other log line that is associated with any column family will be reported. So, you find in the log information about column families whose options you don't know.
The text was updated successfully, but these errors were encountered: