From 1796944f0cbebdabb12e294ebae5ca4a66ee67a8 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:50:09 +0000 Subject: [PATCH 01/12] splited the case of a PR that came from the original repo and the case when the request came from a fork, in the latter case will try to trit it as not a PR --- .../workflows/check_license_and_history.yml | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index 5fef42e08..2955d9b36 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,15 +20,19 @@ jobs: - name: Get changed files id: changes run: | - echo "files added or changed in a PR: " - git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' - echo "added or changed files: " - git diff --name-only --diff-filter=ACMRT remotes/origin/main HEAD -- . ':!.github' ':!*.md' - echo "diff_list<> $GITHUB_OUTPUT - git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT - git diff --name-only --diff-filter=ACMRT remotes/origin/main HEAD -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT - echo "EOF" >> $GITHUB_OUTPUT - + if [ ${ github.event.pull_request.head.repo.full_name != 'org/repo' }]; then + echo "files added or changed in a PR that came from the speedb repo: " + git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' + echo "diff_list<> $GITHUB_OUTPUT + git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT + echo "EOF" >> $GITHUB_OUTPUT + else + echo "added or changed files: " + git diff --name-only --diff-filter=ACMRT remotes/origin/main HEAD -- . ':!.github' ':!*.md' + echo "diff_list<> $GITHUB_OUTPUT + git diff --name-only --diff-filter=ACMRT remotes/origin/main HEAD -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT + echo "EOF" >> $GITHUB_OUTPUT + fi - name: list new files run: | echo "New files in this PR ${{ steps.changes.outputs.diff_list }}" From 0f51fb226551d8b89f8a8019f6068e0be178db02 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:53:26 +0000 Subject: [PATCH 02/12] splited the case of a PR that came from the original repo and the case when the request came from a fork, in the latter case will try to trit it as not a PR --- .github/workflows/check_license_and_history.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index 2955d9b36..a8486f588 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,7 +20,7 @@ jobs: - name: Get changed files id: changes run: | - if [ ${ github.event.pull_request.head.repo.full_name != 'org/repo' }]; then + if [ ${ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' }]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' echo "diff_list<> $GITHUB_OUTPUT From bf1185c79543131cff481a1bd6d98d6e3ff01caa Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:54:58 +0000 Subject: [PATCH 03/12] splited the case of a PR that came from the original repo and the case when the request came from a fork, in the latter case will try to trit it as not a PR --- .github/workflows/check_license_and_history.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index a8486f588..e4fd03e91 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,7 +20,7 @@ jobs: - name: Get changed files id: changes run: | - if [ ${ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' }]; then + if [ ${ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' } ]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' echo "diff_list<> $GITHUB_OUTPUT From 070433c69e7447cb6f4f26d4cce828a185136f4c Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:56:36 +0000 Subject: [PATCH 04/12] splited the case of a PR that came from the original repo and the case when the request came from a fork, in the latter case will try to trit it as not a PR --- .github/workflows/check_license_and_history.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index e4fd03e91..733e0f15c 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,7 +20,7 @@ jobs: - name: Get changed files id: changes run: | - if [ ${ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' } ]; then + if [ ${{ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' }} ]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' echo "diff_list<> $GITHUB_OUTPUT From 7ad3f13139aa5ab85330022d78f24cf205666f93 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:59:27 +0000 Subject: [PATCH 05/12] splited the case of a PR that came from the original repo and the case when the request came from a fork, in the latter case will try to trit it as not a PR --- .github/workflows/check_license_and_history.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index 733e0f15c..a71015d98 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,6 +20,7 @@ jobs: - name: Get changed files id: changes run: | + echo ${{ github.event.pull_request.head.repo.full_name }} if [ ${{ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' }} ]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' From 04191e4b65a6ae4e5dece874480bb125161b00a8 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:02:03 +0000 Subject: [PATCH 06/12] edit README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 45eeea079..1d6fe933c 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ A first-of-its-kind, community-led key-value storage engine, designed to support modern data sets. -Speedb is a 100% RocksDB compatible, drop-in library, focused on high performance, optimized for modern storage hardware and scale, on-premise and in the cloud. +Speedb is a 100% RocksDB compatible, drop-in library, focused on high performance, optimized for modern storage hardware and scale, on-premise and in the cloud We strive to simplify the usability of complex data engines as well as stabilize and improve performance for any use case. We are building an open source community where RocksDB and Speedb users and developers can interact, improve, share knowledge, and learn best practices. You are welcome to join our community, contribute, and participate in the development of the next generation storage engine. We welcome any questions or comments you may have. Please use issues to submit them, and pull requests to make contributions. From 8aa1d32127dc4e5fe07cae0527e68369d4da8821 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:05:24 +0000 Subject: [PATCH 07/12] unedit README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1d6fe933c..c40e12a38 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ A first-of-its-kind, community-led key-value storage engine, designed to support modern data sets. -Speedb is a 100% RocksDB compatible, drop-in library, focused on high performance, optimized for modern storage hardware and scale, on-premise and in the cloud +Speedb is a 100% RocksDB compatible, drop-in library, focused on high performance, optimized for modern storage hardware and scale, on-premise and in the cloud. We strive to simplify the usability of complex data engines as well as stabilize and improve performance for any use case. We are building an open source community where RocksDB and Speedb users and developers can interact, improve, share knowledge, and learn best practices. You are welcome to join our community, contribute, and participate in the development of the next generation storage engine. We welcome any questions or comments you may have. Please use issues to submit them, and pull requests to make contributions. From 6bfaef214b986aa0e7e90afa36fce0ce547826b7 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:06:22 +0000 Subject: [PATCH 08/12] added a dummy file --- removeMe.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 removeMe.txt diff --git a/removeMe.txt b/removeMe.txt new file mode 100644 index 000000000..9afb93426 --- /dev/null +++ b/removeMe.txt @@ -0,0 +1 @@ +123ZZ From e0d905f907158a3dc7cb199c0fd96a3186b46c86 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:23:54 +0000 Subject: [PATCH 09/12] updated the logic in check_license workflow --- .github/workflows/check_license_and_history.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index a71015d98..ddb372dd4 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -20,12 +20,13 @@ jobs: - name: Get changed files id: changes run: | - echo ${{ github.event.pull_request.head.repo.full_name }} - if [ ${{ github.event.pull_request.head.repo.full_name != 'speedb-io/speedb' }} ]; then + echo ${{github.event.pull_request.head.repo.full_name}} + if [ ${{ github.event.pull_request.head.repo.full_name == 'speedb-io/speedb' }} ]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' echo "diff_list<> $GITHUB_OUTPUT git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT + git diff --name-only --diff-filter=ACMRT remotes/origin/main HEAD -- . ':!.github' ':!*.md' >> $GITHUB_OUTPUT echo "EOF" >> $GITHUB_OUTPUT else echo "added or changed files: " From b350b17974eeef14c7ad447ef73e702592f5bdef Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:27:09 +0000 Subject: [PATCH 10/12] deleted the dummy file that was previously added for a test --- removeMe.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 removeMe.txt diff --git a/removeMe.txt b/removeMe.txt deleted file mode 100644 index 9afb93426..000000000 --- a/removeMe.txt +++ /dev/null @@ -1 +0,0 @@ -123ZZ From 115df60bd24913e8890e42b1ba7a384ede1675d6 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Mon, 26 Feb 2024 16:36:01 +0000 Subject: [PATCH 11/12] fix History --- HISTORY.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HISTORY.md b/HISTORY.md index c70734a61..995a70b15 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -2831,4 +2831,4 @@ Because of that, Options::disable_seek_compaction is now obsolete. It is still a * Optimized locking for `Get()` -- [1fdb3f](https://github.com/facebook/rocksdb/commit/1fdb3f7dc60e96394e3e5b69a46ede5d67fb976c) -- 1.5x QPS increase for some workloads * Cache speedup - [e8d40c3](https://github.com/facebook/rocksdb/commit/e8d40c31b3cca0c3e1ae9abe9b9003b1288026a9) * Implemented autovector, which allocates first N elements on stack. Most of vectors in RocksDB are small. Also, we never want to allocate heap objects while holding a mutex. -- [c01676e4](https://github.com/facebook/rocksdb/commit/c01676e46d3be08c3c140361ef1f5884f47d3b3c) -* Lots of efforts to move malloc, memcpy and IO outside of locks +* Lots of efforts to move malloc, memcpy and IO outside of locks. From adaa5456829cea0f6044e5d11f02b516277440d0 Mon Sep 17 00:00:00 2001 From: maxb-io <105273783+maxb-io@users.noreply.github.com> Date: Tue, 27 Feb 2024 06:04:43 +0000 Subject: [PATCH 12/12] replaced quotes in the if condition in check_licence_and_history --- .github/workflows/check_license_and_history.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/check_license_and_history.yml b/.github/workflows/check_license_and_history.yml index ddb372dd4..3accc16ac 100644 --- a/.github/workflows/check_license_and_history.yml +++ b/.github/workflows/check_license_and_history.yml @@ -21,7 +21,7 @@ jobs: id: changes run: | echo ${{github.event.pull_request.head.repo.full_name}} - if [ ${{ github.event.pull_request.head.repo.full_name == 'speedb-io/speedb' }} ]; then + if [ ${{ github.event.pull_request.head.repo.full_name == "speedb-io/speedb" }} ]; then echo "files added or changed in a PR that came from the speedb repo: " git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} -- . ':!.github' ':!*.md' echo "diff_list<> $GITHUB_OUTPUT