Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Allow for full customization of all hard-coded strings #145

Closed
jlmmns opened this issue Jun 7, 2019 · 3 comments
Closed

[i18n] Allow for full customization of all hard-coded strings #145

jlmmns opened this issue Jun 7, 2019 · 3 comments

Comments

@jlmmns
Copy link

jlmmns commented Jun 7, 2019

As of now, only days and months can be customized.

It would be nice if we could customize all hard-coded strings, such as:

  • units (seconds, minutes, hours, etc.)
  • since (in, almost, ago, etc.)
@spencermountain
Copy link
Owner

hey @jlmmns yeah you're right - what are you thinking about for i18n units, this?

spacetime.now().add(1, 'journée')

otherwise a dupe of #110

@jlmmns
Copy link
Author

jlmmns commented Jun 7, 2019

@spencermountain Thanks for the quick follow-up! The API should stay English only, I'm sure.

I'm talking about the formatting. So, it's related to #110, indeed. But more than just the "ago" string.
Pretty much every hard-coded string that spacetime displays, should be customizable.

I'd want to try to contribute with a PR, but I don't have any time, unfortunately.

@spencermountain
Copy link
Owner

merging with #110
cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants