Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loading spinner to components #190

Open
spences10 opened this issue May 18, 2022 · 3 comments
Open

Add Loading spinner to components #190

spences10 opened this issue May 18, 2022 · 3 comments

Comments

@spences10
Copy link
Owner

Is your feature request related to a problem? Please describe.
When the components come into view, although they have their height set they are essentially empty until the embed loads.

Describe the solution you'd like
Add a loading spinner to show in the place of the empty space.

@paoloricciuti
Copy link

I might take a look at this as soon as I have time if is still Todo.

@spences10
Copy link
Owner Author

Yeah, still on the todo list 😄

@raulfdm
Copy link

raulfdm commented Mar 15, 2023

+1 for that.

I'd say not only adding a spinner but allowing users to pass a slot that would be rendered while loading:

<Tweet tweetId="1234">
  <MyLoader slot="load" />
</Tweet>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants