diff --git a/electrum/bip21.py b/electrum/bip21.py index bcf6bd361dfd..6b9cdf2fc256 100644 --- a/electrum/bip21.py +++ b/electrum/bip21.py @@ -43,6 +43,9 @@ def parse_bip21_URI(uri: str) -> dict: for k, v in pq.items(): if len(v) != 1: raise InvalidBitcoinURI(f'Duplicate Key: {repr(k)}') + if k.startswith('req-'): + # we have no support for any req-* query parameters + raise InvalidBitcoinURI(f'Unsupported Key: {repr(k)}') out = {k: v[0] for k, v in pq.items()} if address: diff --git a/electrum/tests/test_util.py b/electrum/tests/test_util.py index 1767bc8bfdc8..f64af19d311e 100644 --- a/electrum/tests/test_util.py +++ b/electrum/tests/test_util.py @@ -149,6 +149,13 @@ def test_parse_URI_invalid(self): def test_parse_URI_parameter_pollution(self): self.assertRaises(InvalidBitcoinURI, parse_bip21_URI, 'bitcoin:15mKKb2eos1hWa6tisdPwwDC1a5J1y9nma?amount=0.0003&label=test&amount=30.0') + @as_testnet + def test_parse_URI_unsupported_req_key(self): + self._do_test_parse_URI('bitcoin:TB1QXJ6KVTE6URY2MX695METFTFT7LR5HYK4M3VT5F?amount=0.00100000&label=test&somethingyoudontunderstand=50', + {'address': 'TB1QXJ6KVTE6URY2MX695METFTFT7LR5HYK4M3VT5F', 'amount': 100000, 'label': 'test', 'somethingyoudontunderstand': '50'}) + # now test same URI but with "req-test=1" added + self.assertRaises(InvalidBitcoinURI, parse_bip21_URI, 'bitcoin:TB1QXJ6KVTE6URY2MX695METFTFT7LR5HYK4M3VT5F?amount=0.00100000&label=test&req-test=1&somethingyoudontunderstand=50') + @as_testnet def test_parse_URI_lightning_consistency(self): # bip21 uri that *only* includes a "lightning" key. LN part does not have fallback address