Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add svg width height property support #72

Closed
wants to merge 3 commits into from
Closed

add svg width height property support #72

wants to merge 3 commits into from

Conversation

ndee02
Copy link
Contributor

@ndee02 ndee02 commented Jan 11, 2023

proposed implementation for #71

yuja
yuja approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version mostly looks good to me, thanks.

sphinxcontrib/plantuml.py Outdated Show resolved Hide resolved
@yuja
Copy link
Collaborator

yuja commented Mar 2, 2023

Pushed as 772e67f, thanks!

@yuja yuja closed this Mar 2, 2023
@ndee02 ndee02 mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndee02 @yuja