Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup: path resolution during 'sphinx.cmd.make_mode' cleanup #13158

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Fixup: path resolution during 'sphinx.cmd.make_mode' cleanup #13158

merged 2 commits into from
Jan 3, 2025

Conversation

jayaddison
Copy link
Contributor

@jayaddison jayaddison commented Nov 25, 2024 •
edited
Loading

Feature or Bugfix

  • Bugfix

Purpose

  • Fixup for make clean.

Detail

  • Remove redundant and incorrect double-resolution of build dir content paths.
  • Also, ensure that the resolved build dir is used to begin the cleanup search.

Relates

@jayaddison jayaddison requested a review from jfbu December 1, 2024 20:38
jfbu
jfbu approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jfbu jfbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This said I tested only on macOS. (with Python 3.12)

@jayaddison
Copy link
Contributor Author

Thanks @jfbu - I'll add that I've tested this locally using Debian Linux, also using version 3.12 of Python.

@AA-Turner AA-Turner added this to the 8.2.0 milestone Jan 3, 2025
@AA-Turner AA-Turner merged commit f59f978 into sphinx-doc:master Jan 3, 2025
23 checks passed
@jayaddison jayaddison deleted the issue-13157/make-mode-clean branch January 3, 2025 11:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfbu jfbu jfbu approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.

Current master breaks make clean
3 participants
@jayaddison @jfbu @AA-Turner