Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized variable that will cause problem in Blinksformer.java #1

Open
lzccc opened this issue Jun 2, 2020 · 1 comment
Open
Assignees

Comments

@lzccc
Copy link
Contributor

lzccc commented Jun 2, 2020

In

if(className.startsWith(Profiler.entryClass)) {
return shouldInstrument;
}
if we didn't specify Profiler.entryClass, this line of code will cause a problem when instrumenting classes. Maybe we could change it to

String tmp = Profiler.entryClass; 
    if(className.startsWith(tmp==null? " " : tmp)) {
      return shouldInstrument;
    }
@VijayKrishna
Copy link
Member

Good call. It should really be:

if (Profiler.entryClass != null && className.startsWith(Profiler.entryClass)) {
   ...
}

Does that make sense? if it does, can you send out a Pull request to make this change? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants