You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
line 569 will overwrite whatever value that set by line 567, this problem will cause endProfiling() in profiler class never be invoked. Should we change line 569 to:
@lzccc great question. Actually this code needs to be cleaned up, and the correct thing to do here will be to get rid of lines 569 and 570, as they are hardcoded for a single project :) We are able to configure these entry methods and classes for a blinky-core run on the terminal anyway, so such hard coded values here are not necessary.
So, let's do this:
I will add some documentation around how pass in configurable entry class and methods to blinky-core
@lzccc can you send out a simple PR that removes lines 569 and 570 above? thanks!
blinky-core/src/org/spideruci/analysis/dynamic/Profiler.java
Lines 560 to 572 in f7132da
endProfiling()
in profiler class never be invoked. Should we change line 569 to:?
The text was updated successfully, but these errors were encountered: