Skip to content

Commit 05d8d77

Browse files
committed
improved
Signed-off-by: Aminu Oluwaseun Joshua <[email protected]>
1 parent 751ce5d commit 05d8d77

File tree

3 files changed

+7
-44
lines changed

3 files changed

+7
-44
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/app/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ spin-serde = { path = "../serde" }
1313
thiserror = { workspace = true }
1414

1515
[dev-dependencies]
16-
spin-manifest = { path = "../manifest" }
1716
toml = { workspace = true }
18-
tokio = { workspace = true }
17+
tokio = { workspace = true }

crates/app/src/lib.rs

Lines changed: 6 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -346,61 +346,26 @@ pub fn retain_components(
346346
mod test {
347347
use std::collections::HashSet;
348348

349-
use spin_manifest::schema::v2::{self, ComponentSpec, Trigger};
350-
351349
use super::*;
352350

353-
fn locked_trigger(
354-
trigger_type: String,
355-
mut trigger: v2::Trigger,
356-
) -> anyhow::Result<LockedTrigger> {
357-
fn reference_id(spec: v2::ComponentSpec) -> toml::Value {
358-
let v2::ComponentSpec::Reference(id) = spec else {
359-
unreachable!("should have already been normalized");
360-
};
361-
id.as_ref().into()
362-
}
363-
364-
if let Some(id) = trigger.component.map(reference_id) {
365-
trigger.config.insert("component".into(), id);
366-
}
367-
368-
Ok(LockedTrigger {
369-
id: trigger.id,
370-
trigger_type,
371-
trigger_config: trigger.config.try_into()?,
372-
})
373-
}
374-
375351
pub fn locked_app() -> LockedApp {
376352
LockedApp {
377353
spin_lock_version: Default::default(),
378354
must_understand: Default::default(),
379355
metadata: Default::default(),
380356
host_requirements: Default::default(),
381357
variables: Default::default(),
382-
triggers: vec![locked_trigger(
383-
"http".to_owned(),
384-
Trigger {
385-
id: Default::default(),
386-
component: Some(ComponentSpec::Reference(
387-
"empty".to_string().try_into().unwrap(),
388-
)),
389-
components: Default::default(),
390-
config: Default::default(),
391-
},
392-
)
393-
.unwrap()],
358+
triggers: vec![LockedTrigger {
359+
id: "trigger".into(),
360+
trigger_type: "dummy".into(),
361+
trigger_config: toml::from_str(r#"component = "empty""#).unwrap(),
362+
}],
394363
components: vec![LockedComponent {
395364
id: "empty".to_owned(),
396365
metadata: Default::default(),
397366
source: LockedComponentSource {
398367
content_type: "application/wasm".to_owned(),
399-
content: locked::ContentRef {
400-
source: Some("does-not-exist.wasm".to_owned()),
401-
inline: None,
402-
digest: None,
403-
},
368+
content: Default::default(),
404369
},
405370
env: Default::default(),
406371
files: Default::default(),

0 commit comments

Comments
 (0)