-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to add any new bills due to lack of default currency (6.1.0) #1229
Comments
EDIT: The reason is that originally a currency was set, many years ago. It remained set, but since the service used by this project is no longer available, I guess that broke things. Setting manually to "No currency" allowed creation of new bills again. However I'm not going to close this, as this is still a bug. |
You mean that the project was created with a currency that no longer exists? Can you look in the database to see what is the exact value of the currency for your project? |
That would be: The code around currencies is fragile, I would not be surprised if there are loopholes. Let's figure out the issue and add a testcase. |
Interesting, thanks.
I was not even aware of this, and it's clearly something we should fix. Relying on external services is indeed a bad idea in the first place. We might want to completely change the way we're dealing with external currencies. I know that for instance in cospend they let you specify the conversion rate. |
I have same problem, now project is unusable, I can't add any transactions Now ihatemoney calls this API https://api.exchangerate.host/latest?base=USD which need api key to use, we need to predefine currencies to make it work without external api calls |
I have encountered the same issue on ihatemoney.org, can confirm @lbeltrame's quick fix works there too |
As a quick fix, we can probably hard-code the list of currencies. This should allow adding bills in the same currency as the project currency. It seems to be the use-case of @lbeltrame and @Arvil here, since we prevent converting a project to "no currency" as soon as there are bills in different currencies. The longer-term fate of the currency feature is discussed here: #1232 |
I have the same problem. I am not able to post a new note in the money buster app and in the server. |
Workaround added in #1240, and released as 6.1.1 |
As the subject says, it is impossible to add new bills because the form prevents submitting, because the currency field is empty. This doesn't work via API as well because the API returns that currency is a required field.
There was an issue opened a couple of years ago, but it was closed (and it doesn't tell whether the issue was fixed or not).
Setup:
Checked database migrations and everything should be fine.
I couldn't extract meaningful information via logs, but I haven't raised the debug level yet.
The text was updated successfully, but these errors were encountered: