Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Spiral Framework 3.12.0 dispatchers #70

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Jan 17, 2024

What was changed

  1. Since version 3.12, the dispatchers property in Kernel will contain an array of class-strings, not objects. For compatibility with both variants, the ability to work correctly with both strings and objects has been added.
  2. Method canServe will be removed from the interface and a static method 'canServe' accepting 'Spiral\Boot\EnvironmentInterface' in parameters will be added to all dispatchers. The static method will be added to the interface in version 4.0. The package code should be able to work with both method variants.

@msmakouz msmakouz added the enhancement New feature or request label Jan 17, 2024
@msmakouz msmakouz added this to the 2.x milestone Jan 17, 2024
@msmakouz msmakouz requested a review from butschster January 17, 2024 14:20
@msmakouz msmakouz self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03808a8) 43.19% compared to head (912871b) 44.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #70      +/-   ##
============================================
+ Coverage     43.19%   44.57%   +1.37%     
- Complexity      330      332       +2     
============================================
  Files            34       34              
  Lines          1139     1142       +3     
============================================
+ Hits            492      509      +17     
+ Misses          647      633      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msmakouz msmakouz marked this pull request as draft January 18, 2024 13:04
@msmakouz msmakouz marked this pull request as ready for review January 19, 2024 09:26
@msmakouz msmakouz marked this pull request as draft January 19, 2024 10:13
@msmakouz msmakouz marked this pull request as ready for review January 22, 2024 09:52
@butschster butschster merged commit 8b279a6 into 2.x Jan 22, 2024
6 checks passed
@butschster butschster deleted the dispatchers branch January 22, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants