Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute functions should take owned ArrayData #1396

Open
gatesn opened this issue Nov 20, 2024 · 1 comment
Open

Compute functions should take owned ArrayData #1396

gatesn opened this issue Nov 20, 2024 · 1 comment

Comments

@gatesn
Copy link
Contributor

gatesn commented Nov 20, 2024 •
edited
Loading

And then fix up the implementations to mutate in-place.

Also any element-wise operation.

Actually... why not everything?
@gatesn gatesn changed the title CastFn to take ArrayData by ownership CastFn, FillForwardFn to take ArrayData by ownership Nov 20, 2024
@lwwmanning lwwmanning mentioned this issue Dec 18, 2024
Closed
@lwwmanning lwwmanning changed the title CastFn, FillForwardFn to take ArrayData by ownership Compute functions to take owned ArrayData Dec 18, 2024
@lwwmanning lwwmanning changed the title Compute functions to take owned ArrayData Compute functions should take owned ArrayData Dec 18, 2024
@lwwmanning
Copy link
Member

Especially after we finish #1518, we should just pass all of the ArrayData arguments for compute functions as owned instead of refs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwwmanning @gatesn