-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: make geometry variable at runtime #102
Comments
To cite @SpiritSuperUser from #212: It might be useful, to make the lattice dimensions adjustable on the fly by adding/deleting a given number of rows in each direction without changing the other parts of the lattice. with this, is would be easier to analyze the effect of boundary conditions and lattice dimensions on a structure. if one adds rows, one might have to think about how and where to initialize the new ones.
|
Some considerations:
Probably it makes sense to only allow this change for the whole collection at once, as otherwise checks for fitting NOS between copy/paste, gneb etc. would have to be added. In order to update spins we need to adequately copy over existing data to a larger (or smaller) array. The spin_positions can be easily re-generated. |
Started work on this on |
#160 should be resolved in order for variable geometry to function properly. |
With 3f2eb1c on |
With f79f5d0 on Except for the basis cell, everything in the What to do when the basis cell is changed? Especially the What to do with atom_types when the lattice is changed? See also issue #143 - how would disorder be treated in contrast to a fixed distribution of atom types in the basis cell? |
The ground work was merged into TODO:
|
Implemented function to re-distribute vector-fields on new Geometries with ef70284. |
I don't know when, but
I believe the QT UI can soon add the corresponding tab permanently and remove the "might break the code" remark (also as features are now more tested since c3422bc). |
Three things must be considered:
The text was updated successfully, but these errors were encountered: