Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core IO: add optional comment string to API and Datawriter functions #338

Closed
GPMueller opened this issue Oct 25, 2017 · 1 comment
Closed

Core IO: add optional comment string to API and Datawriter functions #338

GPMueller opened this issue Oct 25, 2017 · 1 comment
Labels
core enhancement

Comments

@GPMueller
Copy link
Member

GPMueller commented Oct 25, 2017 •
edited
Loading

This would enable the usage of comment strings such as "Image 3 of 10 after 1000 iterations with SIB Optimizer".
Requirement for #166.
Related to changes being made in PR #319.
@smavros smavros mentioned this issue Oct 25, 2017
Merged
smavros added a commit to smavros/spirit that referenced this issue Oct 27, 2017
@smavros
Implemented API writting with optional comment spirit-code#166 spirit…
10037fb 
…-code#338
@GPMueller GPMueller mentioned this issue Nov 17, 2017
Closed
@GPMueller
Copy link
Member Author

Implemented in PR #319 with commit 10037fb and merged with 0b9db55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GPMueller