Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user blocking #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Rishi556
Copy link
Contributor

@Rishi556 Rishi556 commented Feb 9, 2023

Resolves #19

@vaultec81
Copy link
Member

My biggest issue with this is it doesn't let the gateway node know what users are blocked by what nodes. For example let's say the top 5 nodes block X user. Jobs from that user would typically go to those top 5 nodes first, but the gateway doesn't know those 5 nodes blocked that user. Thus, there is no way the gateway can reallocate those jobs to other nodes and get those videos encoded.

If you can add that into the PR I'd feel much more comfortable about releasing something like this.

@vaultec81 vaultec81 added invalid This doesn't seem right help wanted Extra attention is needed labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add A Blocklist For Users
2 participants