-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to select different currency for each transaction #53
Comments
Interesting suggestion! So that would mean:
We’d need to call an API to get conversion rates between currencies. Any API suggestion (cheap, or even better, free) is appreciated. Note that there wouldn’t be that many API calls, if we cache the conversion rates properly. |
Yep! Everything you mentioned is spot on! I just stumbled upon this guy: https://github.com/hakanensari/frankfurter We can also get currency conversions based on the date of the transaction e.g. https://api.frankfurter.app/2019-01-04 |
What do you think about displaying the rate in an input? Allowing to overwrite the live rate may make the app more resilient to service interruptions of the currency API (see the recent issue at ihatemoney). |
Great idea!! |
Might be worth taking a look at https://github.com/sal0max/currencies#features for further options and perhaps implementation details. |
A few thoughts about implementation:
|
Just to chime in, maybe instead of doing the conversion, if there are outstanding balances in other currencies, show them as another section in the balance tab. That way you can keep adding custom currencies and not have to deal with exchanges. Although this can still go in hand with exchanging currencies :) |
I have a use case for this - I do a few classic car trips with a crew of 2 or 2 people. We often travel around Europe and incur costs in GBP, EUR and other currencies. Converting to GBP at the time of the expense with one call to the conversion service would be good - after all, we're not dealing in huge sums and we only ever settle up in our 'base' currency having incurred the costs many days or even weeks before, often in cash exchanged in the distant past (i.e. no-one's really tracking gentle fluctuations). This is probably the most time consuming element of settling up as in the past I've just sat there and manually converted it all with a nominal 'average' rate. |
It would be better to just store the amount and currency in the database, then look up the historical exchange rate and calculate the converted amount later. (Other apps just look at the current exchange rate and calculate all at once.) If you want to support offline mode later the app shouldn't rely on an external API to write to the database. |
Has there been any progress on currency support? |
As for the exchange rate of a currency - in the case of currency exchange, the exchange office charges a certain percentage for itself, and thus the API data will be understated, the same for paying with a card in foreign currency. The best solution would be to get rate from API as a default with the possibility to change it manually to own rate |
If I remember correctly, this is also how Splitwise does it. |
I'm also waiting for this feature... it's in fact the feature that all open source solutions currently lacking. That's why I can't wait to see it and switch to spliit right away :-) |
FEATURE REQUEST: Ability to select different currency for each transaction, similar to splitwise. And choose the currency for reimbursment
The text was updated successfully, but these errors were encountered: