Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry decorator returning SUCCESS when child is INVALID #434

Open
CleanBandit5595 opened this issue Jan 5, 2024 · 1 comment
Open

Retry decorator returning SUCCESS when child is INVALID #434

CleanBandit5595 opened this issue Jan 5, 2024 · 1 comment

Comments

@CleanBandit5595
Copy link

else: # SUCCESS

        else:  # SUCCESS
            self.feedback_message = (
                f"succeeded [status: {self.failures} failure from {self.num_failures}]"
            )
            return common.Status.SUCCESS

This causes the Retry decorator to return SUCCESS when the child's status is INVALID.

Which I believe isn't a wanted functionality, but the problem did arise from my fault, when a behaviour I wrote returning INVALID accidentally. This was, however, hard to debug, since the decorator simply returns success...

@starrye
Copy link
Contributor

starrye commented Mar 11, 2024

INVALID should be an unexpected state, which only occurs during initialization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants