Proxy support based on DW's main configuration #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks logic for me, @splitbrain could you have a look as well? |
|
Well, in principle this makes sense. However, preferably dw2pdf would use DokuWiki's own HTTP client instead of relying on curl. That should be possible by implementing our own \Mpdf\Http\ClientInterface See https://mpdf.github.io/configuration/configuration-v7-x.html#http-client |
|
In this case, please feel free to reject this pull request as I don't have enough time to dig into this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a small patch that solves issue #245 by setting mPDF's
curlProxyandcurlProxyAuthconfiguration variables based on Dokuwiki's proxy configuration (if it is set).Kind regards,
E.B.