From ea49ea0d9543d44e91ac9caafcc18a84ac67606b Mon Sep 17 00:00:00 2001 From: Gaston Thea Date: Tue, 12 Sep 2023 15:49:02 -0300 Subject: [PATCH 1/2] Fix test --- .../android/client/service/splits/SplitChangeProcessorTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/io/split/android/client/service/splits/SplitChangeProcessorTest.java b/src/test/java/io/split/android/client/service/splits/SplitChangeProcessorTest.java index d270ec649..1bddee8c2 100644 --- a/src/test/java/io/split/android/client/service/splits/SplitChangeProcessorTest.java +++ b/src/test/java/io/split/android/client/service/splits/SplitChangeProcessorTest.java @@ -226,7 +226,7 @@ public void creatingWithNullFilterProcessesEverything() { @Test public void creatingWithFilterWithEmptyConfiguredValuesProcessesEverything() { - List filterList = Collections.singletonList(SplitFilter.bySet(Collections.emptyList())); + Map filterList = Collections.singletonMap(SplitFilter.Type.BY_SET, SplitFilter.bySet(Collections.emptyList())); mProcessor = new SplitChangeProcessor(filterList); From 95c88ee4f3a99876463bd3f6acd787c847f99875 Mon Sep 17 00:00:00 2001 From: Gaston Thea Date: Wed, 13 Sep 2023 11:34:34 -0300 Subject: [PATCH 2/2] Fix name --- .../client/service/splits/FeatureFlagProcessStrategy.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/main/java/io/split/android/client/service/splits/FeatureFlagProcessStrategy.java b/src/main/java/io/split/android/client/service/splits/FeatureFlagProcessStrategy.java index fafc48806..2f50f6bbb 100644 --- a/src/main/java/io/split/android/client/service/splits/FeatureFlagProcessStrategy.java +++ b/src/main/java/io/split/android/client/service/splits/FeatureFlagProcessStrategy.java @@ -6,7 +6,6 @@ import io.split.android.client.dtos.Split; import io.split.android.client.dtos.Status; -import io.split.android.client.utils.logger.Logger; interface FeatureFlagProcessStrategy { @@ -37,7 +36,6 @@ class NamesProcessStrategy implements FeatureFlagProcessStrategy { @Override public void process(List activeFeatureFlags, List archivedFeatureFlags, Split featureFlag) { - Logger.v("Processing with names"); // If the feature flag name is in the filter, we process it according to its status. Otherwise it is ignored if (mConfiguredValues.contains(featureFlag.name)) { mStatusProcessStrategy.process(activeFeatureFlags, archivedFeatureFlags, featureFlag); @@ -57,7 +55,6 @@ class SetsProcessStrategy implements FeatureFlagProcessStrategy { @Override public void process(List activeFeatureFlags, List archivedFeatureFlags, Split featureFlag) { - Logger.v("Processing with sets"); if (featureFlag.sets == null || featureFlag.sets.isEmpty()) { archivedFeatureFlags.add(featureFlag); return;