Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete AWS integration when the resource_signalfx_aws_integration is destroyed #566

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

bgola-signalfx
Copy link
Collaborator

Fixes !388

Copy link

github-actions bot commented Feb 13, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (2e65364) to head (b53c5f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #566   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          35       35           
  Lines        2109     2109           
=======================================
  Hits         2001     2001           
  Misses         89       89           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgola-signalfx
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@bgola-signalfx bgola-signalfx force-pushed the ck-3235-move-aws-integration-delete-logic branch from 9744bd3 to 662ca8c Compare February 13, 2025 13:39
@bgola-signalfx bgola-signalfx merged commit d5dcc17 into main Feb 14, 2025
8 checks passed
@bgola-signalfx bgola-signalfx deleted the ck-3235-move-aws-integration-delete-logic branch February 14, 2025 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS integrations removal with metricstreams is not working
2 participants