Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: Moving detector to new definiton #532

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

MovieStoreGuy
Copy link
Collaborator

Context

A lot of work to get to here, however, it means it can start taking over the original code with more confidence.

I need to add some more test around this before it is merged, but I wanted to get some eyes on early just incase something is amiss.

Changes

  • Added new definition for detectors

Extra

Will move out of draft once dependant PRs are done and tests are completed.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 97.95455% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.91%. Comparing base (1b7f771) to head (97f497a).

Files with missing lines Patch % Lines
internal/definition/detector/resource.go 95.04% 4 Missing and 2 partials ⚠️
internal/definition/detector/schema.go 98.99% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   96.56%   96.91%   +0.35%     
==========================================
  Files          29       33       +4     
  Lines        1309     1749     +440     
==========================================
+ Hits         1264     1695     +431     
- Misses         31       37       +6     
- Partials       14       17       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MovieStoreGuy MovieStoreGuy marked this pull request as ready for review October 18, 2024 01:16
@MovieStoreGuy MovieStoreGuy merged commit f121683 into splunk-terraform:main Oct 22, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants