Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP integration add new auth method #546

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

anosek-an
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Nov 14, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (c5428d6) to head (5ab65d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          35       35           
  Lines        2059     2059           
=======================================
  Hits         1957     1957           
  Misses         85       85           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anosek-an
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@anosek-an anosek-an merged commit a93a94b into splunk-terraform:main Nov 14, 2024
8 checks passed
@anosek-an anosek-an deleted the add-wif branch November 14, 2024 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@atoulme
Copy link
Contributor

atoulme commented Nov 16, 2024

@anosek-an would you please add your team as codeowners of the files you touched? This way you will make sure you are in the loop of any changes. Thanks!

@anosek-an
Copy link
Collaborator Author

@atoulme I don't see a codeowners file in this repo. Should I add one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants