Forbid extra fields in YMLs #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable ACS deployment. reduce non-blocking warnings thrown by appinspect api by updating some automatically generated app files.
to default.meta
in contentctl.py. Print out what is returned from ACS, even on success.
… that was accidentally dropped. set extra='forbid' for SecurityContentObject
|
Note that the |
… should not be in the yml
string from drilldown
to automatically create drilldowns. We will likely remove this, but let's keep it now for purposes of discussion.
committing. see previous commit message.
Fix savedsearches path issue
remove "cloud" from the security_domain enum
just bumping version for release
Enable acs deploy + appinspect warnings
bump version in prep for release
Ensure we print the right field for data_source
Testing on Datasource changes
to computed_field
field for investigation
pydantic object definitions.
don't declare py3.13 compat
|
This PR has been open for a long time and, as such, has been deprecated in favor of the following PR with similar changes: This PR is being closed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra, missing field to the lookup.py model called max_matches that was accidentally dropped. set extra='forbid' for SecurityContentObject
This PR is on hold pending significant, structural changes to Detection YMLs with respect to Risk Based Alterting (RBA) content:
#263