Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KV pairs should be quoted #10

Open
brandonganem opened this issue Jun 13, 2016 · 5 comments
Open

KV pairs should be quoted #10

brandonganem opened this issue Jun 13, 2016 · 5 comments

Comments

@brandonganem
Copy link

KV pairs in the log should be quoted to ensure proper field use in Splunk.

@TheProducer835
Copy link

quotes would only be required if there were spaces in the key or value. Splunk Automagically recognizes key=value and auto extracts as field=value - is there some behavior you are seeing to the contrary?

@brandonganem
Copy link
Author

You're right, the issue is there are no quotes when there are spaces in the logs currently. For example:
Mon Jun 13 18:00:28 EDT 2016 name=PlayerEvent event_id= game_time=3220 world=World Name x=-94 y=151 z=262 action=player_connect player=xxxxxx message=You are not whitelisted on this server!

@TheProducer835
Copy link

Goodpoint. That field is new and should have quotes. Not sure it is required on all though.

@brandonganem
Copy link
Author

I'm inclined to agree. Doesn't look like many need quotes, just a few that could have spaces.

Or better yet, move the output to JSON ;)

@TheProducer835
Copy link

I second that! I don't think there is a reason to keep it k=v honestly.
@mzeb might have insight as to why it was K=V to begin with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants