Check backup path for nil also #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 30, 2022
houndci-bot
reviewed
Sep 30, 2022
|
Why this is not merged yet? @sporkmonger I think this is a great fix for a common issue on containers. |
|
I'm just commenting here to add that this fixes #53 so that GitHub will cross-link this PR with that issue. @sporkmonger are you still maintaining this? Let us know if you need help Edit: I hadn't actually tried this PR when I initially left this comment. While the cross-linking is still good to have, this PR didn't fully solve my problem. It fixed the call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanly handles missing ifconfig and ip command such as went in a docker image