Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to update project failing #1096

Open
hazendaz opened this issue Nov 28, 2024 · 6 comments
Open

Attempts to update project failing #1096

hazendaz opened this issue Nov 28, 2024 · 6 comments

Comments

@hazendaz
Copy link
Member

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'jdk.internal.loader.ClassLoaders$AppClassLoader@5ffd2b27-org.sonar.server.plugins.ServerPluginManager': Initialization of bean failed; nested exception is Plugin Findbugs [findbugs] requires at least Sonar Plugin API version 10.14.0.2599 (current: 10.11.0.2468)

Getting issues like this and not sure how its getting downgraded as dependency tree does not show that. Happens with 9.x as well.

Additionally if I try latest sonar version it fails with non descriptive error.

Not sure what is causing the issues but would like to get fixed as project was considerably out of date.

@gtoison
Copy link
Contributor

gtoison commented Nov 29, 2024

How are you getting these errors (and what are they exactly)? I mean, how are you running SonarQube (with orchestrator from the integration tests? which version?)
There were so many changes recently that I lost track

@hazendaz
Copy link
Member Author

hazendaz commented Dec 5, 2024

ok so on this, if I update the sonar artifacts (9/10) to the latest which are currently sitting in renovate dashboard as closed, the error pops up that it says it wants older version. I cannot see exactly where that was happening from. The message up there is what it states, switching it slightly back then it works fine. So using 10.14 for example, I'm struggling to see where 10.11 comes from.

Yes there were many changes, renovate stopped working because there was account issues. I fixed those and builds started working so I launched all. Looks like still many more to go. nodejs section in this tends to be that way as it seems nodejs teams release constantly every time a file is touched.

@gtoison
Copy link
Contributor

gtoison commented Dec 5, 2024

The sonar artifacts should stay on the version corresponding to the earliest SonarQube supported, which is 9.9 LTS. For a given SonarQube version there are several related dependencies (the plugin API, the java plugin, the java version) and they need to be on the right version.
Upgrading the plugin API or the java plugin to the latest version is not a good idea because they are usually released before a compatible SonarQube server exists.
The matrix build here overrides these maven properties so there's a full build (compile, unit tests, integration tests) on multiple SonarQube version, currently 9.9.7 and 10.7
In the end the release is executed the default (non overridden) versions from the pom.xml so these should for the earliest version, or it will break compatibility with SonarQube 9.9

Now regarding the nodejs section, it is not functional in its current state and I could not find the time to look into it.
It was added to automate the "SonarSource part" of the release process which used to involve posting a release message on their forum, plus creating a pull request here: https://github.com/SonarSource/sonar-update-center-properties/pulls
Now they have dropped the requirement for the forum post, and I'm doing the pull request manually.
At the very least the renovate pull request should be throttled (or grouped?) because there isn't much point cluttering the git history with all these commits

@gtoison
Copy link
Contributor

gtoison commented Feb 14, 2025

Hey @hazendaz
Would it be possible to adjust the renovate settings? I see that you're merging a lot renovate PRs but most of them aren't right:

  • All the PR touching the typescript action aren't right because that thing does not work at all, nobody stepped in it fix so I think it should be removed
  • The PR to upgrade SpotBugs or its plugins aren't right because the metadata and docs aren't updated at the same time

I am all for automation but the way this is currently working is not right: the vast majority of the renovate commits are broken in some way

@hazendaz
Copy link
Member Author

Hey @hazendaz Would it be possible to adjust the renovate settings? I see that you're merging a lot renovate PRs but most of them aren't right:

* All the PR touching the typescript action aren't right because that thing does not work at all, nobody stepped in it fix so I think it should be removed

* The PR to upgrade SpotBugs or its plugins aren't right because the metadata and docs aren't updated at the same time

I am all for automation but the way this is currently working is not right: the vast majority of the renovate commits are broken in some way

On the second item, there is a way to add a script to run a post action. That could address items you are wanting updated at same time so that it is not a manual event. Can you outline or possibly point to a commit where that was done last and I'll see if I can get a script together that will address that.

On the first, I agree they are not really tested but nearly every one was minor updates so they are probably right, just noisy. I can add an ignore I think to stop suggesting in that package since its non working anyways. If that part isn't really necessary, then maybe the right option is just deleting it as you note.

In meantime, I stopped merging things until these concerns can be addressed. Thanks.

@gtoison
Copy link
Contributor

gtoison commented Feb 24, 2025

Here are commits where renovate upgraded SpotBugs or a plugin:
8a8ecb8
670334e

And the corresponding commits with all the changes needed:
35926e7
540ca0c

I have started working on simplifying the metadata build in the sq-10 branch but haven't touched it in a while due to time constraints on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants